Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sidebar]: Duplicate Collapse Button Display and Graph Does Not Shift Left Side After Collapsing and TLDR #2431

Merged
merged 1 commit into from
Nov 1, 2024
Merged

[Sidebar]: Duplicate Collapse Button Display and Graph Does Not Shift Left Side After Collapsing and TLDR #2431

merged 1 commit into from
Nov 1, 2024

Conversation

aliraza556
Copy link
Contributor

@aliraza556 aliraza556 commented Nov 1, 2024 •
edited
Loading

Problem:

  • The sidebar's collapse button is displayed twice, which leads to a duplicated button in the UI. Additionally, when the sidebar is collapsed, the graph does not shift to the left as expected
  • Also Tooltip is not show all sidebar icons.

closes: #2429

Issue ticket number and link:

Evidence:

https://www.loom.com/share/3d02c76e86ba4bfca90bacbc9d46faa0

image

image

image

Acceptance Criteria:

  • Only one collapse button is displayed in the sidebar.
  • The graph correctly shifts to the left side after collapsing the sidebar.
  • Should be Tooltip is show.

@aliraza556
Copy link
Contributor Author

Hi @Rassl, @tomsmith8, Please merge this PR.

@aliraza556
Copy link
Contributor Author

@tomsmith8, @Rassl, Also fixed TLDR Background Allows Clicks Behind Modals

@Rassl Rassl merged commit 37cc246 into stakwork:master Nov 1, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rassl Rassl Rassl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sidebar]: Duplicate Collapse Button Display and Graph Does Not Shift Left Side After Collapsing
2 participants
@aliraza556 @Rassl